Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Soe sequence of events #85

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Soe sequence of events #85

wants to merge 7 commits into from

Conversation

comorbidity
Copy link
Contributor

Created SOE Sequence Of Events because reasons

  1. linking FHIR resources based on FHIR Resource date "period" when encounter reference is not available
  2. QA/verification that FHIR resources are not missing links

Currently there is only ONE file that does this and reports with weekly counts.
Future work may include SQL templates and other refactoring, this was done in isolation to not break main branch.

@comorbidity comorbidity linked an issue Jul 21, 2023 that may be closed by this pull request
SOE "Sequence of events" table needed for linking resources to FHIR Encounter #74
Closed
dogversioning
dogversioning previously requested changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@dogversioning dogversioning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of general things:

  • it would be nice to use unique names for the intermediate CTAS queries
  • SELECT table.* should be avoided for unplanned consequences
  • We'll have to do a SqlFluff pass, though that can be right at the end.

cumulus_library/studies/core/soe_sequence_of_events.sql Outdated Show resolved Hide resolved
cumulus_library/studies/core/soe_sequence_of_events.sql Outdated Show resolved Hide resolved
@dogversioning dogversioning self-requested a review August 23, 2023 18:39
comorbidity and others added 4 commits August 24, 2023 15:28
mikix
mikix approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@mikix mikix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not really review the sql - but the rest looks good!

cumulus_library/template_sql/templates.py Outdated Show resolved Hide resolved
cumulus_library/studies/core/builder_soe.py Show resolved Hide resolved
@dogversioning dogversioning dismissed their stale review August 25, 2023 15:07

resolved via commits

@dogversioning dogversioning mentioned this pull request Aug 28, 2023
Closed
@dogversioning dogversioning added this to the 2.2 milestone Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikix mikix mikix approved these changes

@dogversioning dogversioning Awaiting requested review from dogversioning

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Sequence of events
Development

Successfully merging this pull request may close these issues.

SOE "Sequence of events" table needed for linking resources to FHIR Encounter
3 participants
@comorbidity @mikix @dogversioning