Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add UFO-R11 controller support #1137

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

yoavipm
Copy link

@yoavipm yoavipm commented Sep 28, 2023

No description provided.

@yoavipm
Copy link
Author

yoavipm commented Sep 29, 2023

@pieter @azuwis @phidauex @aceindy please review

@boardlord1
Copy link
Contributor

Hi @yoavipm could you update your branch to include the fixes from the main branch? Thanks :)

@BenJamesAndo
Copy link

Will this also work with the Zigbee ZS06? I have both a UFO-R11 & ZS06. They're functionally identical. The only difference is the ZS06 runs off usb cable power instead of batteries.

I'm probably going to add 5 or 6 different brands of aircons using these Zigbee blasters so I'm stocked to see this might be getting merged soon.

Additionally I recently found a fork that adds support of using these with ZHA. I've tested it and it works great.
davidrpfarinha@c839bde

@vassilis-panos
Copy link
Member

Since I don't have the ability to test this particular controller, if you find it works stable it could merge.

@boardlord1
Copy link
Contributor

I've setup yoavipm's fork for a friend with this controller and it worked perfectly. As he said it is exactly like an mqtt controller, but an additional prefix is needed for the payload: ir_code_to_send:

@vassilis-panos
Copy link
Member

Why do we need to define a new controller then? Something like a mqtt prefix that can be passed to the configuration should do the job.

@boardlord1
Copy link
Contributor

I guess it's for convenience - it was just easy set this controller in the json and copy-paste the codes direct from zigbee2mqtt. But @yoavipm might be able to give more context.

@yoavipm
Copy link
Author

yoavipm commented Dec 14, 2023

It was defined that way so that you could set it up in the json easily. it is a different device/controller after all, even though it uses the mqtt under the hood.
Adding prefix to configuration is too specific in my opinion. I'll rebase with main soon.

@junknstuff
Copy link

Why do we need to define a new controller then? Something like a mqtt prefix that can be passed to the configuration should do the job.

Chiming in since I am using both ZS06 and UFO-R11 daily. In my experience, it's not just a prefix. There is also the need to close out the quotations. The combination of the prefix and having to close out the quotes makes it more prone to formatting errors and generally more challenging to setup the json code file.

I setup my own template which allows me to double-check the formatting much easier without the codes. I replace the @@@ with the recorded IR codes accordingly.

https://pastes.io/szxvgv7zev

I have no expertise to say what can/should change, just wanted to share my experience, it is quite the learning curve to make sure it's the code and/or the formatting that may be holding back someone's json code.

@yoavipm
Copy link
Author

yoavipm commented Dec 16, 2023

I don't get this discussion regarding a new controller.. this is indeed a new MOES Zigbee controller . it works well, and all you have to do is change the name of your controller, why should we make this more complicated with prefix stuff in configuration file..
anyways, I'm using it for a good few months and it works flawlessly . I also implemented a new feature for dedicated ON/OFF code combinations regarding ELECTRA ACs, where changing the mode doesn't turn on the AC, but that's a discussion for a different topic.

@yoavipm
Copy link
Author

yoavipm commented Dec 16, 2023

Hi @yoavipm could you update your branch to include the fixes from the main branch? Thanks :)

Done

@zastik
Copy link

zastik commented Mar 4, 2024

I don't get this discussion regarding a new controller.. this is indeed a new MOES Zigbee controller . it works well, and all you have to do is change the name of your controller, why should we make this more complicated with prefix stuff in configuration file.. anyways, I'm using it for a good few months and it works flawlessly

I'd like to test this out, and have installed your fork, but can't figure out what to set the controller_data as in configuration.yaml
Would you mind please sharing what you use?

@svyatogor
Copy link

svyatogor commented Mar 5, 2024

UFO-R11 uses a completely different IR command format. Thankfully broadlink can be converted to a supported format. Check out this gist, it takes broadlink compatible definition file and spits out Tuya's version.

At least on the zigbee2mqtt I can specify controller_data: "zigbee2mqtt/IR Bedroom/set/ir_code_to_send" to put command in the correct property field.

@BenJamesAndo
Copy link

Check out this gist, it takes broadlink compatible definition file and spits out Tuya's version.

Could you link to the gist? I'd be interested in doing some conversions.

@BenJamesAndo
Copy link

@djcrawleravp
Copy link

Sorry, can anyone explainme how do I import that gist? i have 3 RM4 pro but I'm switching for the tuya one :/

@BenJamesAndo
Copy link

Sorry, can anyone explainme how do I import that gist? i have 3 RM4 pro but I'm switching for the tuya one :/

First make sure python is installed. Then download broadlink_to_tuya.py. Then in a terminal run python broadlink_to_tuya.py 1000.json
1000.json being an example of the SmartIR code that is configured for a Broadlink device.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants