Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics module spams during shutdown #234

Open
mgobec opened this issue Apr 4, 2017 · 1 comment
Open

Metrics module spams during shutdown #234

mgobec opened this issue Apr 4, 2017 · 1 comment
Labels
bug
Milestone
2.0.1.

Comments

@mgobec
Copy link
Member

mgobec commented Apr 4, 2017 

ERROR [metrics-timer] 2017-04-04 08:19:29,732 MetricsCollector.java:133 - Exception while reading attribute Value of type java.lang.Object
javax.management.InstanceNotFoundException: org.apache.cassandra.metrics:type=ThreadPools,path=request,scope=CounterMutationStage,name=ActiveTasks
        at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getMBean(DefaultMBeanServerInterceptor.java:1095) ~[na:1.8.0-zing_16.12.3.0]
...
        at io.smartcat.cassandra.diagnostics.module.metrics.MetricsCollector.collectMeasurements(MetricsCollector.java:124) ~[cassandra-diagnostics-core-1.4.0.jar:na]
        at io.smartcat.cassandra.diagnostics.module.metrics.MetricsModule$MetricsTask.run(MetricsModule.java:66) [cassandra-diagnostics-core-1.4.0.jar:na]
        at java.util.TimerThread.mainLoop(Timer.java:555) [na:1.8.0-zing_16.12.3.0]

There is a ton of these during shutdown sequence.
We should listed to the shutdown event and stop diagnostics modules.

INFO  [StorageServiceShutdownHook] 2017-04-04 08:19:26,999 Gossiper.java:1467 - Announcing shutdown
@mgobec mgobec added the bug label Apr 4, 2017
@mgobec mgobec added this to the 1.4.1. milestone Apr 4, 2017
@nbozic-zz nbozic-zz modified the milestones: 1.4.4. - Various bug fixes, 1.4.3. - Kafka reporter Apr 17, 2017
@mgobec
Copy link
Member Author

mgobec commented Apr 25, 2017

@nbozic This should be moved to post 2.0 rework

@nbozic-zz nbozic-zz modified the milestones: 2.0.1., 1.4.5. - Metrics module improvements and bug fixes May 4, 2017
nbozic-zz pushed a commit that referenced this issue May 14, 2017
@nbozicns
Fixes #254 and #234.
6c969c9 
- added functional test for metrics module
- fixed spawning of multiple exceptions when Cassandra is shutting down
mgobec pushed a commit that referenced this issue May 15, 2017
@nbozicns @mgobec
Nbozic metrics exception spawn (#266)
2d402ac 
* Removing logback and sleep pause to make tests faster.

* Fixes #254 and #234.

- added functional test for metrics module
- fixed spawning of multiple exceptions when Cassandra is shutting down
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.0.1.
Development

No branches or pull requests
2 participants
@mgobec @nbozic-zz