add context #312
add context #312
Conversation
jmank88
force-pushed
the
BCF-2887-context-propagation
branch
from
40940f9
to
32ff16a
Compare
jmank88
force-pushed
the
BCF-2887-context-propagation
branch
from
32ff16a
to
fe20a39
Compare
jmank88
force-pushed
the
BCF-2887-context-propagation
branch
from
fe20a39
to
efffc37
Compare
jmank88
force-pushed
the
BCF-2887-context-propagation
branch
from
efffc37
to
4ea6bf4
Compare
jmank88
had a problem deploying
to
integration
GitHub Actions
Failure
jmank88
force-pushed
the
BCF-2887-context-propagation
branch
from
4ea6bf4
to
10f448b
Compare
jmank88
had a problem deploying
to
integration
GitHub Actions
Failure
jmank88
had a problem deploying
to
integration
GitHub Actions
Failure
jmank88
force-pushed
the
BCF-2887-context-propagation
branch
from
daf024d
to
56d7407
Compare
jmank88
requested review from
topliceanu,
pedrovsg and
krebernisak
as code owners
pkg/loop/adapter.go
Outdated
There was a problem hiding this comment.
what happened here? unused?
There was a problem hiding this comment.
Yeah it only served to bridge the gap with context.
| @@ -36,7 +36,7 @@ func TestKafkaExporter(t *testing.T) { | |||
| nodes := []NodeConfig{generateNodeConfig()} | |||
| exporter, err := factory.NewExporter(ExporterParams{chainConfig, feedConfig, nodes}) | |||
| require.NoError(t, err) | |||
| envelope, err := generateEnvelope() | |||
| envelope, err := generateEnvelope(ctx) | |||
There was a problem hiding this comment.
I'm confused by the introduction of context here. Most of these methods have no concurrency in their implementation - ctx is not needed and won't help.
Take generateEnvelope, it produces a structure filled with random values. https://github.com/smartcontractkit/chainlink-common/pull/312/files#diff-be6ec1c2691cf18a8a73b7ea25c78bab3dc41d5bccde1df3e9626310e849306bR454-R477
There was a problem hiding this comment.
What is the relevance of concurrency? We are motivated by carrying request scoped values for tracing.
This func calls generateContractConfig, which calls median.StandardOnchainConfigCodec.Encode, which now requires a context.
https://smartcontract-it.atlassian.net/browse/BCF-2887
Supports: