Skip to content

Commit

Permalink
changed spammy error log to debug (#13153)
Browse files Browse the repository at this point in the history
  • Loading branch information
patrickhuie19 committed May 9, 2024
1 parent 6c0d6b8 commit 3502176
Showing 1 changed file with 3 additions and 7 deletions.
10 changes: 3 additions & 7 deletions core/services/pipeline/runner.go
Original file line number Diff line number Diff line change
Expand Up @@ -457,18 +457,14 @@ func (r *runner) run(ctx context.Context, pipeline *Pipeline, run *Run, vars Var
"run.Inputs", run.Inputs,
)
}
if run.HasFatalErrors() {
l = l.With("run.FatalErrors", run.FatalErrors)
}
if run.HasErrors() {
l = l.With("run.AllErrors", run.AllErrors)
}
l = l.With("run.State", run.State, "fatal", run.HasFatalErrors(), "runTime", runTime)
if run.HasFatalErrors() {
// This will also log at error level in OCR if it fails Observe so the
// level is appropriate
l.Errorw("Completed pipeline run with fatal errors")
l = l.With("run.FatalErrors", run.FatalErrors)
l.Debugw("Completed pipeline run with fatal errors")
} else if run.HasErrors() {
l = l.With("run.AllErrors", run.AllErrors)
l.Debugw("Completed pipeline run with errors")
} else {
l.Debugw("Completed pipeline run successfully")
Expand Down

0 comments on commit 3502176

Please sign in to comment.