switch more EVM components to use sqlutil.DataStore #12856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
jmank88
force-pushed
the
BCF-2978-rm-qopts-evm
branch
from
d4bac24
to
4d6101d
Compare
jmank88
force-pushed
the
BCF-2978-rm-qopts-evm
branch
from
4d6101d
to
acf68a5
Compare
jmank88
force-pushed
the
BCF-2978-rm-qopts-evm
branch
from
acf68a5
to
be06252
Compare
jmank88
force-pushed
the
BCF-2978-rm-qopts-evm
branch
from
be06252
to
614868f
Compare
jmank88
force-pushed
the
BCF-2978-rm-qopts-evm
branch
from
614868f
to
d930925
Compare
jmank88
force-pushed
the
BCF-2978-rm-qopts-evm
branch
from
d930925
to
7d0dcc7
Compare
jmank88
force-pushed
the
BCF-2978-rm-qopts-evm
branch
from
7d0dcc7
to
7bd98ce
Compare
jmank88
force-pushed
the
BCF-2978-rm-qopts-evm
branch
from
7bd98ce
to
8fe6ea6
Compare
jmank88
commented
Apr 17, 2024
jmank88
force-pushed
the
BCF-2978-rm-qopts-evm
branch
from
8fe6ea6
to
3d838a0
Compare
|
dimriou
reviewed
Apr 17, 2024
| @@ -565,55 +565,53 @@ func (lsn *listenerV2) enqueueForceFulfillment( | |||
| } | |||
|
|
|||
| // fulfill the request through the VRF owner | |||
| err = lsn.q.Transaction(func(tx pg.Queryer) error { | |||
There was a problem hiding this comment.
Weird this was a transaction in the first place 🤔
There was a problem hiding this comment.
Yeah, maybe it was just nudged to a confused state from edits over time 🤷
dimriou
approved these changes
Apr 17, 2024
This was referenced Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://smartcontract-it.atlassian.net/browse/BCF-2978
This was extracted from #12456