add vrf replay logs #12887
add vrf replay logs #12887
Conversation
|
I see you updated files related to
|
| "numBlocksToReplay", numBlocksToReplay, | ||
| "replayStartBlock", replayStartBlock, | ||
| "requestTimeout", lsn.job.VRFSpec.RequestTimeout, | ||
| "finalizedLatestBlock", latestBlock.FinalizedBlockNumber, |
There was a problem hiding this comment.
Would this already be added by line 123?
ll := lsn.l.With(
"latestFinalizedBlock", latestBlock.FinalizedBlockNumber,
"latestBlock", latestBlock.BlockNumber,
"fromTimestamp", fromTimestamp)
There was a problem hiding this comment.
right. let me remove the overlapping ones.
|
I see you added a changeset file but it does not contain a tag. Please edit the text include at least one of the following tags:
|
| case "1": // eth mainnet | ||
| case "3": // eth ropsten | ||
| case "4": // eth rinkeby | ||
| case "5": // eth goerli | ||
| case "11155111": // eth sepolia | ||
| case "1", "3", "4", "5", "11155111": // eth mainnet, robsten, rinkeby, goerli, sepolia |
There was a problem hiding this comment.
I kind of like the previous style of 1 chainId per line. It makes things much easier to read.
There was a problem hiding this comment.
I learned previous style is wrong. all of these went to default:
case "1": // eth mainnet
case "3": // eth ropsten
case "4": // eth rinkeby
case "5": // eth goerli
There was a problem hiding this comment.
Ah. This style only works for languages with explicit break. Is it possible to something like below?
case
"1", // eth mainnet
"3", // eth ropsten
"4", // eth rinkeby
"5": // eth goerliThere was a problem hiding this comment.
sure can change it
core/services/vrf/delegate.go
Outdated
| if err != nil { | ||
| return nil, err | ||
| } | ||
| d.lggr.Debugw("Creating services for job spec", "job", string(marshalledJob)) |
There was a problem hiding this comment.
Can consider adding more tags like key hashes, max gas price, etc to make it easier to find within the logs.
There was a problem hiding this comment.
makes sense. so key hash can be derived from "uncompressedKey" in the job spec. max gas price is already being printed elsewhere: Key = '0xd13b46290f61dB3E6638bE2746e88F0c04AB883F'\n\n[EVM.KeySpecific.GasEstimator]\nPriceMax = '200 gwei'
There was a problem hiding this comment.
Right. Anything printed can be found as a regex matching the log since tags are not indexed anyway.
|
No description provided.