Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump libocr => fd3cab206b2ca3b7ff207996b95673b2d6303ec4 #12902

Merged
merged 4 commits into from
Apr 22, 2024
Merged

Bump libocr => fd3cab206b2ca3b7ff207996b95673b2d6303ec4 #12902

merged 4 commits into from
Apr 22, 2024

Conversation

samsondav
Copy link
Contributor

Needed for reducing default poll time

@samsondav samsondav requested a review from a team as a code owner April 19, 2024 19:53
@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

jmank88
jmank88 previously approved these changes Apr 19, 2024
View reviewed changes
@samsondav samsondav requested a review from jmank88 April 22, 2024 13:28
jmank88
jmank88 previously approved these changes Apr 22, 2024
View reviewed changes
@augustbleeds
Copy link
Contributor

Need to either cherry-pick the commit here a762913 or make the corresponding changes in the plugins/ directory

augustbleeds
augustbleeds requested changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@augustbleeds augustbleeds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to either cherry-pick the commit here a762913 or make the corresponding changes in the plugins/ directory or else there's risk of the plugin not being properly initialized

jmank88
jmank88 reviewed Apr 22, 2024
View reviewed changes
.changeset/stale-terms-march.md
"chainlink": patch
---

Bump libocr => fd3cab206b2ca3b7ff207996b95673b2d6303ec4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we mention the new feature?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the new feature?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not being used at the moment. But if you want to say it you could say "introduces the ability to report GasPriceSubunits in the median plugin - currently value is ignored"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize it wasn't connected yet. No need to mention then I guess

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds like something with poll time changed though?

@samsondav samsondav requested a review from jmank88 April 22, 2024 14:21
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@samsondav samsondav added this pull request to the merge queue Apr 22, 2024
Merged via the queue into develop with commit d1845e2 Apr 22, 2024
105 checks passed
@samsondav samsondav deleted the MERC-4538-bump-liboc branch April 22, 2024 16:30
This was referenced Apr 24, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmank88 jmank88 jmank88 approved these changes

@augustbleeds augustbleeds augustbleeds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samsondav @augustbleeds @jmank88