Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CapabilityRegistry: add capability version #12996

Merged
merged 7 commits into from
Apr 29, 2024
Merged

CapabilityRegistry: add capability version #12996

merged 7 commits into from
Apr 29, 2024

Conversation

DeividasK
Copy link
Collaborator

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

I see you added a changeset file but it does not contain a tag. Please edit the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@DeividasK DeividasK marked this pull request as ready for review April 26, 2024 14:33
@github-actions GitHub Actions
Copy link
Contributor

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

cds95
cds95 reviewed Apr 27, 2024
View reviewed changes
contracts/src/v0.8/keystone/interfaces/ICapabilityConfiguration.sol
// Solidity does not support generic returns types, so this cannot be part of
// the interface. However, the implementation contract MAY implement this
// function to enable configuration decoding on-chain.
// function decodeCapabilityConfiguration(bytes configuration) external returns (TypedCapabilityConfigStruct config)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove this then?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea was to keep it for informational purposes.

@DeividasK DeividasK added this pull request to the merge queue Apr 29, 2024
Merged via the queue into develop with commit 0a37c0e Apr 29, 2024
105 checks passed
@DeividasK DeividasK deleted the KS-124-public-registry-add-capability-version-get-capabilities branch April 29, 2024 05:51
This was referenced Apr 29, 2024
Closed
Closed
Closed
Closed
Closed
This was referenced Apr 30, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cds95 cds95 cds95 approved these changes

@archseer archseer Awaiting requested review from archseer archseer is a code owner

@bolekk bolekk Awaiting requested review from bolekk bolekk is a code owner

@patrick-dowell patrick-dowell Awaiting requested review from patrick-dowell patrick-dowell is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DeividasK @cds95