get available erc20 for finance payment #13088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shileiwill
force-pushed
the
getAvailableERC20ForPayment
branch
from
7d37d17
to
4ff0d69
Compare
|
RyanRHall
approved these changes
May 3, 2024
| /** | ||
| * @notice returns the amount of a particular token that is withdraw-able by finance admin | ||
| */ | ||
| function getAvailableERC20ForPayment(IERC20 billingToken) external view returns (uint256) { |
There was a problem hiding this comment.
this func name sounds familiar - is this what CCIP uses?
There was a problem hiding this comment.
I think we learnt this naming pattern from CCIP, but not sure if they have the same name tho.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced May 3, 2024
This was referenced May 6, 2024
This was referenced May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.