CCIP price cache use DB timestamp #13133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matYang
commented
May 7, 2024
| ClearGasPricesByDestChain(ctx context.Context, destChainSelector uint64, to time.Time) error | ||
| ClearTokenPricesByDestChain(ctx context.Context, destChainSelector uint64, to time.Time) error | ||
| ClearGasPricesByDestChain(ctx context.Context, destChainSelector uint64, expireSec int) error | ||
| ClearTokenPricesByDestChain(ctx context.Context, destChainSelector uint64, expireSec int) error |
There was a problem hiding this comment.
nothing is consuming this interface yet so safe to modify
jmank88
previously approved these changes
May 7, 2024
mateusz-sekara
previously approved these changes
May 8, 2024
|
mateusz-sekara
approved these changes
May 8, 2024
jmank88
approved these changes
May 8, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@reductionista pointed out that
now()wasn't incrementing was due to test statements being in the same transaction. Switching to usestatement_timestamp(). This timestamp points to start of the statement and can increment in tx.Make expiration logic based on DB timestamp. Not strictly necessary given we don't have application synchronization challenges, but good to be consistent with DB timestamp.