Rebroadcast unconfirmed transactions upon .Connect #1676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spooktheducks
force-pushed
the
feature/rebroadcast-unconfirmed-tx
branch
from
75bb906
to
ebc6bca
Compare
dimroc
suggested changes
Sep 17, 2019
|
|
||
| _, err := txm.SendRawTx(attempt.SignedRawTx) | ||
| if err != nil { | ||
| logger.Warnf("Failed to rebroadcast tx %v: %v", attempt.Hash, err) |
There was a problem hiding this comment.
| func (orm *ORM) UnconfirmedTxAttempts() ([]models.TxAttempt, error) { | ||
| var items []models.TxAttempt | ||
| err := orm.DB. | ||
| Where("confirmed = false"). |
There was a problem hiding this comment.
@j16r @se3000
Technically, this confirmed bool flag is only set when Safe, not on the first confirmation via a receipt. We've opted to use this anyways and rebroadcast txs that might be confirmed but not safe, but warn in that scenario, since that scenario could happen while we're offline anyways. ie:
- tx A is sent, but unconfirmed
- We go offline, but it gets confirmed
- We reconnect and rebroadcast.
Ideally, we would want to rename this column safe and have a separate column confirmed to also identify the mere act of confirmation, or the reception of a tx receipt. That's been captured here: https://www.pivotaltracker.com/story/show/168536671
spooktheducks
force-pushed
the
feature/rebroadcast-unconfirmed-tx
branch
from
ebc6bca
to
f680897
Compare
dimroc
approved these changes
Sep 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/168495946