Remove global state from evm helpers #1684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of the effort of making helpers.ts usable by consumers, the file helpers.ts has had its functions and variables for initializing accounts + roles + personas refactored so that they are no longer globally exposed. Instead, each test that needs personas and roles call initializeRolesAndPersonas() to create their own copy of the variables to use. This removes the dependence on global state that might not be intialized properly either through user error or the require.cache being cleared.
Merged
se3000
reviewed
Sep 17, 2019
| @@ -4,14 +4,22 @@ import { assertBigNum } from '../src/matchers' | |||
| const BasicConsumer = artifacts.require('BasicConsumer.sol') | |||
| const Oracle = artifacts.require('Oracle.sol') | |||
|
|
|||
| let roles | |||
|
|
|||
| before(async () => { | |||
There was a problem hiding this comment.
Could we cut down this boiler plate and call h.initializeRolesAndPersonas() in the module, and then export roles, personas...?
There was a problem hiding this comment.
its asynchronous initialisation so you can't synchronously call it, hence the before hook
There was a problem hiding this comment.
we don't want to use that hook within helpers.ts since that now introduces side-effects on import. it also assumes the importer is using mocha for their test framework, which may not be the case for external module consumers
se3000
approved these changes
Sep 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.