CircleCI pushes releases to dockerhub based on tags and branches #1694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimroc
changed the title
dimroc
force-pushed
the
chores/explorer-tags-for-dockerhub
branch
7 times, most recently
from
009a073
to
5a2b32d
Compare
dimroc
changed the title
dimroc
changed the title
dimroc
force-pushed
the
chores/explorer-tags-for-dockerhub
branch
2 times, most recently
from
68d04cb
to
9232b0f
Compare
|
Successfully builds on tags
|
dimroc
force-pushed
the
chores/explorer-tags-for-dockerhub
branch
from
06bbf3f
to
e9be3ce
Compare
dimroc
commented
Sep 23, 2019
tools/bin/circleci_push_explorer
Outdated
| @@ -0,0 +1,45 @@ | |||
| #!/bin/bash | |||
|
|
|||
| set -ex | |||
There was a problem hiding this comment.
Deliberately left as set -ex to have insight on CI.
felder-cl
reviewed
Sep 23, 2019
tools/bin/circleci_push_chainlink
Outdated
| PROJECT_ROOT=`git rev-parse --show-toplevel` | ||
| pushd $PROJECT_ROOT >/dev/null | ||
|
|
||
| tools/bin/circleci_validate_if_versioned $circle_branch $circle_tag |
There was a problem hiding this comment.
Maybe surround the bash environment variables with "quotation marks"?
There was a problem hiding this comment.
We have other instances in the same file where we confidently don't surround with quotation marks, like the pushd above. I'm going to leave this as is for now.
felder-cl
reviewed
Sep 23, 2019
| # if version tagged, but not master, error. Only master can have versions. | ||
| if [ "$circle_branch" != "master" ] && [ -n "$circle_tag" ] | ||
| then | ||
| echo Not on master \(${circle_branch}\) with git tag version \(${circle_tag}\), erroring. |
felder-cl
reviewed
Sep 23, 2019
tools/bin/gittag2dockertag
Outdated
| if [ -z "$1" ] | ||
| then | ||
| exit 0 # No tag, skip. | ||
| fi |
j16r
reviewed
Sep 23, 2019
| elif [[ "${branch}" =~ ^release\/([a-zA-Z0-9.]+) ]]; then | ||
| echo "${BASH_REMATCH[1]}" | ||
| echo "candidate-${BASH_REMATCH[1]}" |
|
looks good as far as I can tell 👍 |
dimroc
force-pushed
the
chores/explorer-tags-for-dockerhub
branch
from
f5596d9
to
b987a2b
Compare
j16r
approved these changes
Sep 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/n/projects/2235105/stories/168396064
Key features are the support for git tags.
Chainlink Core only:
Explorer only:
Develop branch will update images with the tag
developerRelease candidates will be built when pushing to a branch like
release/0.0.2, resulting in an imagesmartcontract/chainlink:candidate-0.0.2andsmartcontract/explorer:candidate-0.0.2.What isn't in this final PR, but we could readd, is an escape hatch for testing and debugging. I allowed
chores-v.*to be built via tags in order for me to have confidence in the PR. If @thodges-gh you see a need for something like this, let me know.