test flux aggregator default oracle gas limits #2965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
kaleofduty
reviewed
May 21, 2020
| // xs[i] = 0 | ||
| // } | ||
|
|
||
| // for (let l = len - 1; l > 0; l--) { |
There was a problem hiding this comment.
Suggested change
| // for (let l = len - 1; l > 0; l--) { | |
| // for (let l = len; l > 0; l--) { |
There are only two hard things in computer science: cache invalidation, naming things, and off-by-one errors. :-)
There was a problem hiding this comment.
I also suggest doing an assert.deepEqual against a golden output, e.g. for len == 16, you should get [2, 4, 6, 8, 10, 12, 14, 16, 1, 9, 5, 11, 3, 13, 7, 15]
se3000
force-pushed
the
feature/#172815482-median-gas-limit
branch
from
d7375cd
to
0f3c703
Compare
se3000
requested review from
j16r,
RyanRHall,
samsondav and
spooktheducks
as code owners
samsondav
previously approved these changes
May 22, 2020
| @@ -81,7 +81,7 @@ contract FluxAggregator is AggregatorInterface, Owned { | |||
| * funds without the owner's intervention.) | |||
| */ | |||
| uint256 constant private RESERVE_ROUNDS = 2; | |||
| uint256 constant private MAX_ORACLE_COUNT = 42; | |||
| uint256 constant private MAX_ORACLE_COUNT = 77; | |||
There was a problem hiding this comment.
Wow we're really going for broke here ;)
There was a problem hiding this comment.
It was the most we could fit in under 400k.
| await aggregator | ||
| .connect(personas.Carol) | ||
| .addOracles([fakeAddress], [fakeAddress], minMax, minMax, rrDelay) | ||
| function adverserialQuickselectList(len: number): number[] { |
There was a problem hiding this comment.
Shoutout to @kaleofduty.
se3000
force-pushed
the
feature/#172815482-median-gas-limit
branch
from
0f3c703
to
42072cd
Compare
thodges-gh
approved these changes
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.