Solidity 0.7 VRF Consumer Contracts 7️⃣ #4131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
se3000
approved these changes
Apr 2, 2021
samsondav
reviewed
Apr 5, 2021
| * @dev compatibility with older versions. It can't *hurt* to mix in some of | ||
| * @dev your own randomness, here, but it's not necessary because the VRF | ||
| * @dev oracle will mix the hash of the block containing your request into the | ||
| * @dev VRF seed it ultimately uses. |
There was a problem hiding this comment.
So if I don't care about it, should I just pass 0?
Comment on lines
+165
to
+168
| // This is the seed passed to VRFCoordinator. The oracle will mix this with | ||
| // the hash of the block containing this request to obtain the seed/input | ||
| // which is finally passed to the VRF cryptographic machinery. | ||
| uint256 vRFSeed = makeVRFInputSeed(_keyHash, _seed, address(this), nonces[_keyHash]); |
There was a problem hiding this comment.
This comment seems outdated considering the description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.