Remove need to preinstall operator-ui #7785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HenryNguyen5
requested review from
kalverra,
tateexon,
skudasov,
AnieeG,
alexroan,
chainchad,
javuto,
jkongie,
jmank88 and
samsondav
as code owners
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
HenryNguyen5
force-pushed
the
chore/streamline_operator_ui_install
branch
from
ae290df
to
fe96c36
Compare
jmank88
reviewed
Oct 27, 2022
|
Seems like one of the action files has a ton of whitespace changes since it was improperly formatted before, github lets you hide whitespace changes to see the real changes easier |
jmank88
previously approved these changes
Oct 27, 2022
HenryNguyen5
force-pushed
the
chore/streamline_operator_ui_install
branch
from
0d2259b
to
0a42fa0
Compare
HenryNguyen5
added a commit
to smartcontractkit/chainlink-github-actions
that referenced
this pull request
Oct 27, 2022
The operator-ui is installed as part of the docker image build now. See smartcontractkit/chainlink#7785
jmank88
reviewed
Oct 28, 2022
| // then you must first run `make operator-ui` in the root dir to fetch the frontend | ||
| //nolint | ||
| // nolint | ||
| // |
There was a problem hiding this comment.
Was this nolint comment still required? (and is this extra line added by gofmt?)
We'd like to clean them to be proper machine readable comments, like: //nolint:<linter> (no leading space)
There was a problem hiding this comment.
I don't know which specific rule this is for though
jmank88
approved these changes
Oct 28, 2022
chainchad
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up our CI pipeline from the changes made in #7697