Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move chain data #1426

Merged
merged 14 commits into from
Aug 8, 2023
Merged

Conversation

simkasss
Copy link
Contributor

@simkasss simkasss commented Aug 1, 2023

Relates issues

relates #1423

Description

The chains data file moved to features/data in order to use the same chains data source across different products.

Changes

  • The src/features/feeds/data/ folder is moved to src/features/data
  • The supported features field is added to the chains data
  • VRF v2 cost calculator is refactored in order to use chain data from the src/features/data/chains.ts source file

@vercel
Copy link

vercel bot commented Aug 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2023 9:05am

@simkasss
Copy link
Contributor Author

simkasss commented Aug 7, 2023

@dwightjl any updates on the review of this PR? It blocks #1403

Copy link
Contributor

@yacine-benichou yacine-benichou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great job Thanks for this ! I left a nitpick as a comment but otherwise everything looks good.

simkasss and others added 3 commits August 8, 2023 11:00
* Add feed notice capability

---------

Co-authored-by: Yacine Benichou <yacine@mb-q1g67f3cp6.lan>

* Fix typescript issues

* Edits

* More edits not included in previous commit

* Updates

* Fix typo in threshold variable name

---------

Co-authored-by: Yacine Benichou <yacine@mb-q1g67f3cp6.lan>
@yacine-benichou yacine-benichou merged commit 9b30165 into smartcontractkit:main Aug 8, 2023
2 checks passed
simkasss added a commit to simkasss/documentation that referenced this pull request Aug 8, 2023
* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* change to absolute imports

* update imports

* update supportedNetworkShortcut

* Add capability for feed notices (smartcontractkit#1440)

* Add feed notice capability

---------

Co-authored-by: Yacine Benichou <yacine@mb-q1g67f3cp6.lan>

* Fix typescript issues

* Edits

* More edits not included in previous commit

* Updates

* Fix typo in threshold variable name

---------

Co-authored-by: Yacine Benichou <yacine@mb-q1g67f3cp6.lan>

* fix import

---------

Co-authored-by: Dwight Lyle <dwightjl@gmail.com>
Co-authored-by: Yacine Benichou <yacine@mb-q1g67f3cp6.lan>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhance existing content or processes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants