Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EA migration - batch #1 #226
EA migration - batch #1 #226
Changes from 25 commits
a9c9ff9
7ae2bfb
d00485c
88f9f3d
aff743c
b67f5cd
af98026
3741cc1
507e414
d88758f
f6a2ded
9844af4
d687942
d3473cc
a006e1a
d5174da
e2ba252
3769c70
73fd1ab
b959ba6
b5d6268
7a2e510
5fe263c
2eb9dc7
9a12f44
674b974
268d78f
e4d1a19
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like this a lot, setting directly the process.env field, and with a value that is not providing any actual functionality...
But we could tackle this separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. This would be out of scope of this TS migration though.
There is an issue tracking it @ #245.
This file was deleted.