Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

feat: working Agoric initiator #73

Merged

Conversation

michaelfig
Copy link
Contributor

@michaelfig michaelfig commented Oct 22, 2020

@michaelfig michaelfig changed the title feat: first cut at agoric feat: working Agoric initiator Oct 22, 2020
@michaelfig michaelfig marked this pull request as ready for review October 22, 2020 22:46
@RodrigoAD RodrigoAD self-requested a review November 16, 2020 14:58
@RodrigoAD
Copy link
Member

Hi @michaelfig, thanks for the good work. If you could add the necessary tests it would be ready

@michaelfig
Copy link
Contributor Author

Hi @michaelfig, thanks for the good work. If you could add the necessary tests it would be ready

R4R!

@michaelfig michaelfig force-pushed the mfig/add-agoric-initiator branch 2 times, most recently from e09bce1 to c708815 Compare December 9, 2020 15:56
@michaelfig
Copy link
Contributor Author

@RodrigoAD this is ready to go, IMO.

Do note that the Required "imports" check seems to be misconfigured. Instead, it should be "golang/static / Imports". Could you please change this setting in the Github configuration for this repository?

@michaelfig
Copy link
Contributor Author

@RodrigoAD @rigario this is ready for review, PTAL.

@RodrigoAD
Copy link
Member

RodrigoAD commented Feb 24, 2021

Overall looks good, just this final detail. We've recently added prometheus metrics exporting, if you could include it as well. You can follow this:

promLastSourcePing.With(prometheus.Labels{"endpoint": bs.endpointName, "jobid": bs.jobID}).SetToCurrentTime()

@michaelfig
Copy link
Contributor Author

We've recently added prometheus metrics exporting, if you could include it as well.

Done! R4R as soon as the tests pass.

Copy link
Member

@RodrigoAD RodrigoAD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @michaelfig !

@RodrigoAD RodrigoAD merged commit a58f900 into smartcontractkit:master Feb 25, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants