Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build failures on CI #52

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Conversation

jacobkeeler
Copy link
Contributor

Fixes #3473 (alternative to #41)

Enable AM_MAINTAINER_MODE to prevent forced automake run during user build. If automake was present on the user's machine, there were certain conditions where automake would be forced to run again, causing a build failure due to a macro that cannot be included in the repository. This change makes it so automake will never be automatically run

@jacobkeeler jacobkeeler mentioned this pull request Dec 2, 2020
1 task
@Jack-Byrne
Copy link
Collaborator

Jack-Byrne commented Dec 9, 2020

I am having trouble building this bson pr fix in SDL Core.

  • I deleted all mentions of emhashmap and bson from /usr/local
  • I set the bson cmake param GIT_TAG to the commit instead of master ("9a1c54d95d5f0f90bff064eacdbe73d96ce929ea")
  • Clean build of core failing

Reverting GIT_TAG to bson master is building fine

@dboltovskyi
Copy link

@JackLivio Please notice
In case we set GIT_TAG=9a1c54d95d5f0f90bff064eacdbe73d96ce929ea we have received the following error:

src/3rd_party/CMakeFiles/libbson.dir/build.make:95: recipe for target 'src/3rd_party/libbson-prefix/src/libbson-stamp/libbson-update' failed

However in case if GIT_TAG=hotfix/ci_build_failures we have build finished successfully

@Jack-Byrne
Copy link
Collaborator

User error ^, issue resolved.

@jacobkeeler jacobkeeler changed the base branch from master to release/1.2.4 December 9, 2020 20:00
@jacobkeeler jacobkeeler merged commit 73cc53f into release/1.2.4 Dec 9, 2020
@jacobkeeler jacobkeeler mentioned this pull request Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants