Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove UI.SetDisplayLayout implementation #499

Merged
merged 1 commit into from
Feb 16, 2022

Conversation

ShobhitAd
Copy link
Contributor

@ShobhitAd ShobhitAd commented Feb 15, 2022

Since the UI.SetDisplayLayout RPC was removed from the HMI_API.xml in the core implementation of smartdevicelink/sdl_core#3706, the RPC should also be removed from the Generic HMI

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).

Core Tests

  • Send SetDisplayLayout RPC from SDL app. The HMI should recieve an equivalent UI.Show request rather than a UI.SetDisplayLayout request

Core version tested against: develop
Proxy+Test App name tested against: RPC Builder

Summary

Removes the implementation of the UI.SetDisplayLayout RPC

CLA

@ShobhitAd ShobhitAd merged commit e4f8e07 into develop Feb 16, 2022
@ShobhitAd ShobhitAd deleted the fix/remove_ui_setdisplaylayout_implementation branch February 16, 2022 19:40
@ShobhitAd ShobhitAd added this to Completed Bug Fix/ Enhancements in 0.12.0 Release Feb 16, 2022
@Jack-Byrne Jack-Byrne mentioned this pull request Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
0.12.0 Release
Completed Bug Fix/ Enhancements
Development

Successfully merging this pull request may close these issues.

None yet

2 participants