Add widgets API updates #185

mked-luxoft · 2019-08-01T14:43:22Z

Adds updates to API according #2918

kshala-ford · 2019-08-01T16:07:57Z

MOBILE_API.xml

+        <element name="templateTitle" since="6.0">
+            <description>The title of the new template that will be displayed; applies to "Show"</description>
+        </element>
+


This PR should only include widget related changes. Please remove this element from the enum.

fixed in 086a52f

kshala-ford · 2019-08-01T16:08:25Z

MOBILE_API.xml

@@ -871,11 +897,11 @@
        <element name="locationImage" since="4.0">
            <description>The optional image of a destination / location</description>
        </element>
-        
+


Not sure if this delta is needed.

removed in 086a52f

kshala-ford · 2019-08-01T16:08:36Z

MOBILE_API.xml

        <element name="alertIcon" since="6.0">
            <description>The image field for Alert</description>>
        </element>
-        
+


Not sure if this delta is needed

removed in 086a52f

kshala-ford · 2019-08-01T16:13:48Z

This PR implements #164 SDL 0216 Widget Support. @mked-luxoft I reviewed the file. There seems to be an element from another proposal implementation. Please have a look at the review and let me know if you have any questions.

Jack-Byrne · 2019-08-19T21:01:31Z

@mked-luxoft There is a difference in the number of line changes between this PR and the mobile_api.xml changes in core.

Can you please verify that all fields are correct? I went through and see that <struct name="DisplayCapabilities" deprecated="true" since="6.0"> is missing from this PR.

The pr for these changes should try to be an exact copy of the changes in the core pr (or vice versa).

Jack-Byrne

Core's mobile_api.xml changes should align with this pr for the widgets implementation.

theresalech · 2019-08-29T15:41:36Z

@mked-luxoft can you please let us know if you need any more information from us in order to make these changes?

theresalech · 2019-09-18T17:47:42Z

@mked-luxoft following up here. Please advise when this is ready for re-review. Thanks!

mked-luxoft · 2019-09-23T12:58:30Z

@mked-luxoft There is a difference in the number of line changes between this PR and the mobile_api.xml changes in core.

Can you please verify that all fields are correct? I went through and see that <struct name="DisplayCapabilities" deprecated="true" since="6.0"> is missing from this PR.

The pr for these changes should try to be an exact copy of the changes in the core pr (or vice versa).

@JackLivio added and updated in 8daa157

mked-luxoft · 2019-09-23T13:08:44Z

Core's mobile_api.xml changes should align with this pr for the widgets implementation.

@JackLivio i checked the changes and they seem to be the same as in core PR. the difference in line changes might be explained by different versions of file the PRs are based on.

mked-luxoft · 2019-09-23T13:09:14Z

@mked-luxoft following up here. Please advise when this is ready for re-review. Thanks!

@theresalech sorry for delay, this pr is ready for review

Jack-Byrne · 2019-09-24T14:41:58Z

MOBILE_API.xml

@@ -3243,6 +3342,7 @@

    <struct name="RadioControlCapabilities" since="4.5">
        <description>Contains information about a radio control module's capabilities.</description>
+        <!-- need an ID in the future -->


Please remove this

Jack-Byrne · 2019-09-24T14:42:08Z

MOBILE_API.xml

@@ -3328,6 +3428,7 @@

    <struct name="ClimateControlCapabilities" since="4.5">
        <description>Contains information about a climate control module's capabilities.</description>
+        <!-- need an ID in the future -->


Please remove this

fixed on a8b4b19

Jack-Byrne · 2019-09-24T15:18:59Z

MOBILE_API.xml

@@ -2881,6 +2968,7 @@
        <element name="REMOTE_CONTROL"/>
        <element name="APP_SERVICES" since="5.1"/>
        <element name="SEAT_LOCATION" since="6.0"/>
+	<element name="DISPLAYS" since="6.0"/>


Please Fix Spacing

fixed in a8b4b19

theresalech · 2019-09-25T17:48:23Z

@mked-luxoft please advise once you've addressed the PM's feedback, and this PR is ready for re-review. Thank you!

theresalech · 2019-10-01T20:58:18Z

@mked-luxoft, can you please let us know once this feedback has been addressed? We would like to have this resolved before we share the Core 6.0 Release Candidate with the Steering Committee for review on 2019-10-04.

mked-luxoft · 2019-10-02T07:43:09Z

@theresalech PR is ready for re review

theresalech

@JackLivio can you please take a look at the questions I've left in my comments and advise?

Additionally, believe the following changes are still needed, per the proposal. Please let me know if these were included and I missed them, or if they are not needed.

The notification OnHMIStatus should be extended to address a specific window.
Add windowID and templateConfiguration params to Show

Please request changes from the author if needed. Let me know if you need any more information from me, thanks!

MOBILE_API.xml

theresalech · 2019-10-07T14:45:27Z

MOBILE_API.xml

+        <param name="presetBankCapabilities" type="PresetBankCapabilities" mandatory="false" deprecated="true" since="6.0">
+            <description>
+                If returned, the platform supports custom on-screen Presets; see PresetBankCapabilities.
+                This parameter is deprecated and replaced by  SystemCapability using DISPLAYS.


Suggested change

This parameter is deprecated and replaced by SystemCapability using DISPLAYS.

This parameter is deprecated and replaced by SystemCapability using DISPLAYS.

please remove extra space

MOBILE_API.xml

Jack-Byrne · 2019-10-08T14:17:52Z

@theresalech

The notification OnHMIStatus should be extended to address a specific window.

I believe that parameter is added "windowID".

Add windowID and templateConfiguration params to Show

Those were added here

theresalech

@mked-luxoft I've left a couple minor comments for you, regarding spacing and history tags. Please let me know if you have any questions or concerns with addressing. Thanks!

mked-luxoft · 2019-10-11T13:34:39Z

@theresalech comments have been addressed in 6aa7613, pr is ready for re-review

mked-luxoft mentioned this pull request Aug 1, 2019

Feature/widget support smartdevicelink/sdl_core#2980

Merged

1 task

kshala-ford suggested changes Aug 1, 2019

View reviewed changes

mked-luxoft force-pushed the feature/widget_support branch from a75a89f to a9cb906 Compare August 2, 2019 05:17

mked-luxoft closed this Aug 2, 2019

mked-luxoft force-pushed the feature/widget_support branch from a9cb906 to fdc503f Compare August 2, 2019 05:21

mked-luxoft reopened this Aug 2, 2019

Jack-Byrne requested changes Aug 19, 2019

View reviewed changes

iCollin mentioned this pull request Sep 18, 2019

add option for developers to have a tiled menu #181

Closed

mked-luxoft force-pushed the feature/widget_support branch from 086a52f to 74c3167 Compare September 23, 2019 12:50

Add widgets API updates

8daa157

mked-luxoft force-pushed the feature/widget_support branch from 74c3167 to 8daa157 Compare September 23, 2019 12:57

theresalech requested a review from Jack-Byrne September 23, 2019 14:23

iCollin mentioned this pull request Sep 23, 2019

Feature/tiled menus #193

Merged

Jack-Byrne reviewed Sep 24, 2019

View reviewed changes

fixup! Add widgets API updates

a8b4b19

mked-luxoft force-pushed the feature/widget_support branch from 03e8297 to a8b4b19 Compare October 2, 2019 07:41

Jack-Byrne approved these changes Oct 4, 2019

View reviewed changes

theresalech reviewed Oct 7, 2019

View reviewed changes

theresalech requested changes Oct 8, 2019

View reviewed changes

fixup! Add widgets API updates

6aa7613

theresalech approved these changes Oct 14, 2019

View reviewed changes

joeygrover merged commit 6aa7613 into smartdevicelink:version/6_0_0 Oct 15, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add widgets API updates #185

Add widgets API updates #185

mked-luxoft commented Aug 1, 2019

kshala-ford Aug 1, 2019

mked-luxoft Aug 2, 2019

kshala-ford Aug 1, 2019

mked-luxoft Aug 2, 2019

kshala-ford Aug 1, 2019

mked-luxoft Aug 2, 2019

kshala-ford commented Aug 1, 2019

Jack-Byrne commented Aug 19, 2019

Jack-Byrne left a comment

theresalech commented Aug 29, 2019

theresalech commented Sep 18, 2019

mked-luxoft commented Sep 23, 2019

mked-luxoft commented Sep 23, 2019

mked-luxoft commented Sep 23, 2019

Jack-Byrne Sep 24, 2019

Jack-Byrne Sep 24, 2019

mked-luxoft Oct 2, 2019

Jack-Byrne Sep 24, 2019

mked-luxoft Oct 2, 2019

theresalech commented Sep 25, 2019

theresalech commented Oct 1, 2019

mked-luxoft commented Oct 2, 2019

theresalech left a comment •

edited

Loading

theresalech Oct 7, 2019

Jack-Byrne Oct 8, 2019

Jack-Byrne commented Oct 8, 2019

theresalech left a comment

mked-luxoft commented Oct 11, 2019

	This parameter is deprecated and replaced by SystemCapability using DISPLAYS.
	This parameter is deprecated and replaced by SystemCapability using DISPLAYS.

Add widgets API updates #185

Add widgets API updates #185

Conversation

mked-luxoft commented Aug 1, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kshala-ford commented Aug 1, 2019

Jack-Byrne commented Aug 19, 2019

Jack-Byrne left a comment

Choose a reason for hiding this comment

theresalech commented Aug 29, 2019

theresalech commented Sep 18, 2019

mked-luxoft commented Sep 23, 2019

mked-luxoft commented Sep 23, 2019

mked-luxoft commented Sep 23, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

theresalech commented Sep 25, 2019

theresalech commented Oct 1, 2019

mked-luxoft commented Oct 2, 2019

theresalech left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Jack-Byrne commented Oct 8, 2019

theresalech left a comment

Choose a reason for hiding this comment

mked-luxoft commented Oct 11, 2019

theresalech left a comment •

edited

Loading