[SDL 0238] Feature Keyboard Enhancements #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
@ashwink11, please review this PR. |
|
@KhrystynaDubovyk changes approved from the Ford side. |
|
@JackLivio This PR is ready for Livio ready. Thank you! |
|
@jordynmackool this PR is ready for review. Thanks! |
|
@ychernysheva, please update the description of this PR stating that it is "ready for review". Thanks! |
|
@KhrystynaDubovyk the proposal markdown file has been updated per the revisions included in the accepted with revisions review issue: Revise SDL-0238 Keyboard Enhancements. Please make the needed updates to this PR and then tag @jacobkeeler to review when ready. Thanks! |
|
@jacobkeeler Revision changes are added, this PR is ready for review. Thank you! |
jacobkeeler
requested changes
Feb 8, 2021
jacobkeeler
approved these changes
Feb 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #183
This PR is ready for review.
Summary
Adds new structs and enums to MOBILE API and README corresponding to proposal
CLA