Bugfix/issue 392 #409
Merged
Bugfix/issue 392 #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeygrover
reviewed
Feb 8, 2017
| context.startService(intent); | ||
| }catch (SecurityException e){ | ||
| Log.e(TAG, "Process is bad"); | ||
| android.os.Process.killProcess(android.os.Process.myPid()); // Let's exit, we can't start our service |
There was a problem hiding this comment.
We don't want to do this. Killing myPid process will actually kill the entire app. We just want to fail silently here, add a return statement there instead.
joeygrover
reviewed
Feb 8, 2017
| context.startService(intent); | ||
| }catch (SecurityException e){ | ||
| Log.e(TAG, "Security exception, process is bad"); | ||
| return false; // Let's exit, we can't start the service |
There was a problem hiding this comment.
So we actually can't just return false blindly here. If you take a look at the return statement after this for loop you can see we need to actually return something meaningful. I'd move the ping code into a separate method with the try/catch so that we can continue through the loop and return something meaningful.
Something like this:
protected void pingRouterService(Context context,String packageName, String className){
if(context == null || packageName == null || className == null){
return;
}
try{
Intent intent= new Intent();
intent.setClassName(packageName, className);
intent.putExtra(TransportConstants.PING_ROUTER_SERVICE_EXTRA, true);
context.startService(intent);
}catch(SecurityException e){
}
}Now we can call this in isRouterServiceRunning() so we can iterate through all running services even if one throws a SecurityException
joeygrover
approved these changes
Feb 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Protecting against SecurityException found in issue #392