Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the screen manager not being able to clear images #954

Conversation

NicoleYarroch
Copy link
Contributor

Fixes #942

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

Test cases added to the ScreenManagerTests and TextAndGraphicManagerTests classes.

Summary

The blank artwork object was never created due to a bug where the blank artwork could only be created if it was already not null.

Changelog

Bug Fixes
  • Developers can now successfully clear a primary or secondary graphic when using the screen manager.

CLA

@NicoleYarroch
Copy link
Contributor Author

@joeygrover PR is ready for review.

@codecov-io
Copy link

Codecov Report

Merging #954 into develop will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #954      +/-   ##
=============================================
+ Coverage      42.55%   42.59%   +0.03%     
- Complexity      3735     3738       +3     
=============================================
  Files            434      434              
  Lines          23098    23098              
  Branches        2698     2698              
=============================================
+ Hits            9829     9838       +9     
+ Misses         12623    12617       -6     
+ Partials         646      643       -3
Impacted Files Coverage Δ Complexity Δ
...icelink/managers/screen/TextAndGraphicManager.java 51.05% <100%> (+1.17%) 74 <2> (+1) ⬆️
...smartdevicelink/managers/screen/ScreenManager.java 67.36% <0%> (+4.21%) 34% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d329a1...4fc26cb. Read the comment docs.

@BrettyWhite BrettyWhite merged commit 2facdae into smartdevicelink:develop Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants