Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch off XML Report by default #170

Merged
merged 2 commits into from
Sep 5, 2019
Merged

Switch off XML Report by default #170

merged 2 commits into from
Sep 5, 2019

Conversation

dboltovskyi
Copy link
Contributor

@dboltovskyi dboltovskyi commented Jun 28, 2019

Fix: #169

This PR is ready for review.

Summary

Currently ATF creates two reports:

  1. ATF report - is a simple text file with all messages which are sent/or received by ATF through both SDL communication channels: MOBILE and HMI
  2. XML Report - is XML file with the messages plus additional information on actual and expected results

Since (2) is in XML format which has some structure the whole document needs to be rebuilt every time new message sent/received.
Moreover content of the document needs to be stored in internal memory while script is executing.

This lead to significant performance degradation on slow environments in case of long scripts.

Since this report is rarely used nowadays the solution is to switch it off by default.

An alternative solution could be usage of another format (not XML) for this report.
However it requires much more time for implementation and motivation is not strong enough.

Changelog

  • XML Report is switched off in default configuration
  • dependency on excludeReport configuration parameter is removed in ATF Log (1)

CLA

@jacobkeeler jacobkeeler merged commit 2403b45 into develop Sep 5, 2019
@jacobkeeler jacobkeeler deleted the fix/xml_reporting branch September 5, 2019 20:22
@ShobhitAd ShobhitAd mentioned this pull request Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants