SDL ignores accessMode if allowed parameter does not exist in OnRemoteControlSettings

[yang1070]

Bug Report

The parameters of HMI function OnRemoteControlSettings are defined as optional in HMI_API.xml. That means HMI can send a OnRemoteControlSettings notification with

• only allowed parameter
• or only accessMode parameter
• or both parameters.

When SDL receives such notifications, it shall update its internal value and use the new value when needed.

However, the current SDL behavior (please see RCOnRemoteControlSettingsNotification::Run) is to ignore the accessMode parameter if allowed parameter does not exist or allowed=false in the notification.
That means allowed is mandatory and HMI shall always include allowed parameter.

Suggest to update the hmi_integration_guidelines to have a clause that HMI shall
always include allowed parameter if we do not change sdl core.

A better solution is to decouple the dependency of two parameters and update the sdl logic to make the parameters truly optional .
SDL shall do the flowing

if accessMode parameter exist {
SetAccessMode(access_mode);
}
if allowed parameter exist {
if allowed=true {
set_rc_enabled(true);
} else {
DisallowRCFunctionality();
ResetAllAllocations();
set_rc_enabled(false);
}
}

Reproduction Steps

From HMI send a OnRemoteControlSettings notification with only accessMode parameter.

Expected Behavior

SDL update its internal value of accessMode.

Observed Behavior

SDL does not update its internal value of accessMode.

OS & Version Information

• SDL Core Version: 5.0
• Testing Against: HMI

Test Case, Sample Code, and / or Example App

[Paste a link to a PR, gist, or other code that exemplifies this behavior]

[ShobhitAd]

Closed via #3749

[aderiabin]

The issue is reproduced in case HMI sends OnRemoteControlSettings notification without allowed parameter when RC functionality is enabled.

SDL logs is attached
logs_2845.zip

Luxoft are preparing fix for this case.

[jacobkeeler]

Closed via #3792