Release 8.0.0 #3775
Merged
Release 8.0.0 #3775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default constructor of Interger class assigns the min value for the wrapped variable, hoowever it keeps the initialize state us `Uninitialized`. So in case when latter user apply such operations as `++`, `+=` the value will be changed but the state is not. The commit adds ability to change initialize state for the class after mentioned operations. So user does not have to call additionaly `initialize` method.
* Reduce some logs to TRACE level Each time SDL Core receives a video packet from mobile, it generates a large amount of logs. Instead of completely removing them, this commit decreases their levels to TRACE. Head unit systems with video streaming feature can set log output level to DEBUG (or higher) to get rid of the logs. Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
kDefaultHeartBeatTimeout = 5000ms Co-authored-by: Anna Pipko (GitHub) <APipko@luxoft.com>
Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
* Update travis distro to 20.04 * Add cppcheck exclusions for false positives * Fix cppcheck issues
…2502) * SDL respond UNSUPPORTED_RESOURCE on SystemRequest (QUERY_APPS) if SDL is below version 4.0 * answer review comments Co-authored-by: Collin <iCollin@users.noreply.github.com>
* replace applicable X++ with ++X * replace applicable X-- with --X * change for loop updates
…2582) * SDL sends wrong OnHMIStatus for voice app in case of a phone call. Once SDL received OnEventChanged(Phone_Call, true) from HMI, it should send OnHMIStatusUpdate with new HMILevel. Expected HMILevel for voice communication application is "LIMITED", but it is "FULL". PhoneCallHmiState should take into account voice communication app as an additional check. * Fix for state_controller unit tests. Due to changes in a logic for PhoneCallHmiState, unit tests have to be updated as well. ApplicationType enum is removed since it is not actual anymore. As a result, PrepareHMIStateResults functions are modified according to new application types and updated expected HMI states. Tests for NaviStreaming HMI state are enabled. NaviStreamingHmiState is used for these tests instead of VideoStreamingHmiState. New tests for different application types are added. * fix styling issues for state_controller_test * Fix hmi state merge conflicts * Revert test code * Fix unit test * Style Co-authored-by: JackLivio <jack@livio.io>
* Add change to return response with requestType from the sample_policy_manager * Remove unrequired logs
* fix respond on SDL.GetListOfPermission request * Error response in case when we could not collect permissions Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
* fix: store app info JSON file in AppStorageFolder * Update test cases to store app info JSON file in AppStorageFolder Co-authored-by: Sho Amano <samano@xevo.com>
* fix crash in libusb callback handling * Answer review; removing redundant logger * Respond review comment, fixed logger. * Removed usb_connection.cc.orig * Update src/components/transport_manager/src/usb/libusb/usb_connection.cc Co-authored-by: Collin <iCollin@users.noreply.github.com> * Update src/components/transport_manager/src/usb/libusb/usb_connection.cc Co-authored-by: Collin <iCollin@users.noreply.github.com> Co-authored-by: yurii <ypostolov> Co-authored-by: Collin <iCollin@users.noreply.github.com>
* parse all values from one ini file open * wrap ini_read_value to open file for ini_file_test.cc * update profile tests, fix handle leak * refactor ini_parse_line * Apply suggestions from code review Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com> * parse ini file in to smart object * remove ini_file changes * fix style * small optimization, parse key first * restore open/close config functions * deprecate ini_file * Revert "restore open/close config functions" This reverts commit a03c694. * move ini parsing to Profile::ParseConfiguration * add DEPREACTED to ini_file * don't print deprecated warnings from test file that is dedicated to deprecated methods * add macros to ini_file.cc * check style Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
* Implement 3rd-party Boost logger * Add boost log config file * Implement log filtering and formatting for the different sinks * Fix Timestamp calculation * Fix function trace string * Implement setting to disable particular sinks * Add append option to file sinks * Telnet logger configuration * Add cmake flag to switch beetween loggers * Remove log4cxx appender include * Style fix * Modify BoostLogConfig file for tests to match the log4cxx properties file * Exclude log4cxx related libraries * Address review comments * Add changes to only install boost log if the correct LOGGER_NAME is set * Fix implementation for removing disabled sinks * Add note for isEnabledFor function * Address review comment * Fix smartobject linking error * Address review comments
…2601) * Fix core prematurely sends success for DeleteInteractionChoiceSet. DeleteInteractionChoiceSetRequest was contain implementation, according to that, SDL never not waits for HMI response and sends to Mobile response (success = true, resultCode = "SUCCESS"). This PR provides changes, that remove that implementation. Also, according to requirements, when at-least on of HMI VR_DeleteCommand response will contains any ERROR result code, except WARNINGS, SDL has to send response with that error code and success_result as false. And if on of HMI VR_DeleteCommand response will contains at-least one WARNINGS resulst_code, SDL has to send to Mobile response with WARNINGS and success_result as true. * Address review comments * fixup! Address review comments * Update src/components/application_manager/rpc_plugins/sdl_rpc_plugin/src/commands/mobile/delete_interaction_choice_set_request.cc Co-authored-by: Collin <iCollin@users.noreply.github.com> Co-authored-by: Andrii Kalinich <AKalinich@luxoft.com> Co-authored-by: Collin <iCollin@users.noreply.github.com>
* Add mobile responce with disallowed by user params * Answer PR comments * Answer PR comments * Update fix according to new hierarchy * fixup! Update fix according to new hierarchy * fixup! Update fix according to new hierarchy Co-authored-by: Andrii Kalinich <AKalinich@luxoft.com> Co-authored-by: Dmitriy Boltovskiy <dboltovskyi@luxoft.com>
* Deprecated redundant code * Remove unit tests for deprecated methods Co-authored-by: Andrii Kalinich <AKalinich@luxoft.com>
) * Fixed SDL sends appName in vrSynonyms and ttsName in case of lower and upper bound values in json file * Update src/components/application_manager/src/application_manager_impl.cc Co-authored-by: Shobhit Adlakha <ShobhitAd@users.noreply.github.com> * Update src/components/application_manager/src/application_manager_impl.cc Co-authored-by: Shobhit Adlakha <ShobhitAd@users.noreply.github.com> * ttsName is defined as array Co-authored-by: Dmitriy Boltovskiy <dboltovskyi@luxoft.com> Co-authored-by: Shobhit Adlakha <ShobhitAd@users.noreply.github.com> Co-authored-by: yurii <ypostolov>
* only call Json::Value::operator[] if it is object type * short object check * validate value[data].isArray()
* Append LD_LIBRARY_PATH in daemon.sh * Update src/appMain/daemon.sh Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com> Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
sliderPosition was set to 0 (an invalid value) in the mobile response if an ABORTED result was received from the HMI without this parameter.
* when non-existant app sends request reply app not registered * fix unit tests
`EndpointProperty.version` is defined as an optional value, but was being used as a mandatory one. Also makes `service` property unique in `endpoint_properties` to prevent duplicate entries
…s in the API without leaking memory (#3703)
* Test github action * Build Core * Fix path * Add submodules * Move path * Debug policy cmake paths * Debug lines * Change build directory * Print sources * Change core path * ls debug * Log cmake version * Try ubuntu 18 * Set Cmake version * Change cmake depdency * Remove version wildcard * Debug collect sources * More debug messages * Check filtered files * Remove bad policy path exclude * Try caching 3rd party * Fix env var * Update 3rd party path * Fix path * Remove env var * Fix space * Update path * Update core path * Fix boost install path * Add 3rd party arch path * Set LD_LIBRARY_PATH * Add check style * Fix cache path * Update README badge status * Move 3rd party build path * Remove Travis * Move cache call earlier * Fix syntax * Conditional mkdir * Add debug line * Add logs * Fix syntax * Fix syntax * Remove log lines * Use boost logger * Update cache * Remove -j * Top level boost include * Adjust boost includes * Remove boost logger * Invalidate cache * Update CMakeLists.txt * Update CMakeLists.txt * Update CMakeLists.txt * Update CMakeLists.txt * Update sdl_core_github_ci.yml * Update CMakeLists.txt * Update CMakeLists.txt * Update CMakeLists.txt * Add pull request action
* clear any parent reference to the state being erased even when it is the begin state * Apply suggestions from code review Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com> Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
* WebSocketServerTransportAdapter::Store write to last state * hold lock until we set dict or decide not to
* Add missing internal error codes to security manager * Add internal error notification to SSL handshake failure * Remove unused handshake result * Add unit tests for new error codes Co-authored-by: JackLivio <jack@livio.io>
#3784) * Check specifically for invalid HMI level before suspending notifications Checking for main window ID caused a very rare race condition where the notification was not suspended when necessary
* Fix wrong behavior of RCOnRemoteControlSettingsNotification Looks like `kAllowed` parameter was swithing on/off the RC functionality even if it was not present and previous value should be taken. Processing of `kAllowed` and `kAccessMode` was split on two separate and independent functions make it really isolated. Processing of both parameters was aligned, so now core does not perform extra actions if one of parameter is missing.
There was found a misprint for a VR interface in `ChangeRegistration` request. Because of that, there might be a situations when HMI responds to one part of request faster than another part was actually sent. All required ordering and checks were updated.
* Added RC plugin extension after PTU * Add new event `kAppHmiTypesChanged` Co-authored-by: OlhaVorobiova <olha.vorobiova@dxc.com>
* Fix early IsRegistered state of application Mark application as registered only when app registration was finalized and all corresponding requests were sent to HMI. This prevents data races in case when language has been changed by HMI and application is in intermediate registration state yet. * fixup! Fix early IsRegistered state of application
#3785) * Removed the unit that interrupted the sequence of closing the connection to the device via usb * Update logic for USB in transfer * fixup! Update logic for USB in transfer Co-authored-by: Andrii Kalinich <AKalinich@luxoft.com>
* Add initial states for pending applications This would prevent crashes for cases when app will be attempted to be activated. * Fix UpdateAppList content * Fix checks in SDL.ActivateApp * Fix unit tests
jacobkeeler
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supported Specifications
Features
[SDL 0328] Modernize Ubuntu Support V20 LTS
[SDL 0236] Update mismatch in TireStatus structure
[SDL 0189] Restructuring OnResetTimeout
[SDL 0192] Button Subscription response from HMI
[SDL 0205] Avoid Custom button subscription in case HMI incompatibility
[SDL 0264] Separating the change of Audible status and the change of HMI Status
[SDL 0338] Remove Unused Files From SDL Core
[SDL 0317] Add missing internal error codes to security manager
Bug Fixes
SDL Core crash in RegisterAppInterface if app disconnects during resumption
Core generates a lot of logs during streaming
SDL does not set initialize state for the Integer type
Icons should be stored in dedicated folder
SDL behavior in case 'HeartBeat' param is empty
SDL must respond UNSUPPORTED_RESOURCE to mobile app in case SDL 4.0 feature is required to be ommited in implementation
Change post-increments to pre-increments
SDL does not respond to SDL.GetListOfPermission with appId in case there are no specific permissions for the app
Location of application info file (app_info.dat) is fixed to current directory
Need to protect the HMICapabilities object from concurrent access
"ini_read_value" performance issue
Unclear message dump in protocol handler unit test (when a test case fails)
Fix crash in libusb callback handling
Core prematurely sends success for DeleteInteractionChoiceSet
Core Deadlocks on Shutdown when Mobile tries to Connect and No HMI is Available
SendLocation with one OR more allowed params and one OR more disallowed params by user
Remove unused functionality from MediaManager
[SDL4.0]SDL sends appName in vrSynonyms and ttsName in case of lower and upper bound values of params in json file
Core Crash noticed with Invalid PTU
daemon.sh overwrites LD_LIBRARY_PATH
Incorrect behavior during processing of erroneous Slider responsive with
sliderPositionparameterUnregisterAppInterface: SDL doesn't reply APPLICATION_NOT_REGISTERED for not registered application
API Schema objects around recursive API structure VideoStreamingCapability are leaking
SDL saves wrong custom_vehicle_data_mapping_url version in the DB and sends it in the next ignition cycle
Core Leaks Websocket Sessions
SDL fails to build with EXTENDED_MEDIA_MODE=ON
Check for invalid enum result code in CommandRequestImpl::SendResponse
Boost Logger Implementation
Return requestType in sample policy manager response
Remove HMI PTU decryption flag
SDL Core only populates GetUserFriendlyMessage content in EXTERNAL_PROPRIETARY mode
Add missing fields to PT Snapshot
Type defining without interface name in HMI_API.xml
CMake warning when EXTERNAL_PROPRIETARY flag is used
Resumption for menuLayout does not occur within SetGlobalProperties, AddSubMenu RPCs
Remove references to UI.GetCapabilities response parameter systemCapabilities.displayCapabilities
SDL response with "GENERIC_ERROR" in case request ResetGlobalProperties ("USER_LOCATION")
SDL deletes nested commands and sub menues in a wrong order
SDL ignores accessMode if allowed parameter does not exist in OnRemoteControlSettings
SDL doesn't increase the timeout if the driver’s permission pop up is needed [GetInteriorVehicleDataConsent]
'AppIconsFolderMaxSize' in smartDeviceLink.ini cannot be configured to be less than 100MB
SDL must set media app to FULL and NOT_AUDIBLE in case this app is activated during phone call
SDL doesn't ignore value of 'frameInfo' field for 'Single' and 'First' frames
SDL crashes when the HMI sends UI.OnTouchEvent with the 'ts' param has a value greater than maxvalue (not valid)
Core does not check AudioStreamingState when starting audio service
Discrepancy Between Policy Table Languages and Supported Languages
SDL process empty structure as valid from HMI
SDL destroys currently running mobile app requests on app unregistration
CCB: Change command request inheritance structure
SDL stops Video service in case if HMI doesn't respond to Navi.StartAudioStream request
Core isn't sending all HMI Status Updates
CCB: Crash related to HandleOnEvent
Core sends SendHandshakeData query with type NOTIFICATION
Fix descriptions for AudioControlCapabilities and SeatControlCapabilities
SDL crash during SetInteriorVehicleData request after PTU in case App is registered with appHMIType 'MEDIA'
Core dump during language change
Miscellaneous Changes
Remove Deprecated Methods SDL Core 8.0.0
Remove deprecated/unused ini files