Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regarding Method formatters::CFormatterJsonSDLRPCv2::fromString #80

Closed
ojmakke opened this issue Apr 17, 2015 · 1 comment
Closed

Regarding Method formatters::CFormatterJsonSDLRPCv2::fromString #80

ojmakke opened this issue Apr 17, 2015 · 1 comment

Comments

@ojmakke
Copy link

ojmakke commented Apr 17, 2015

Path: components/formatters/include
In file: CFormatterJsonSDLRPCv2.hpp
Method: inline bool CFormatterJsonSDLRPCv2::fromString

Looking at the following:

Json::Value root;
Json::Reader reader;
namespace strings = NsSmartDeviceLink::NsJSONHandler::strings;
bool result = reader.parse(str, root);

The variable root is not initialized. Is the reader.parse looking intentionally for an empty string in the str variable?

If so, what is the reasoning behind this?

Thank you

@ojmakke
Copy link
Author

ojmakke commented Apr 17, 2015

Nevermind, root is the output if successfully parsed.

@ojmakke ojmakke closed this as completed Apr 17, 2015
LuxoftAKutsan pushed a commit that referenced this issue Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant