protect pt_ from concurrent access #1962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fronneburg do we have issue with policy table race conditions? |
|
@LuxoftAKutsan In our testing we hit an issue with this in the LTS branch. We found a SIGSEGV crash where the tombstone clearly showed one thread in CacheManager::ApplyUpdate, while the other thread was in CacheManager::CheckPermissions. This PR is simply attempting to move our fix for that into the "develop" branch here. |
|
Can one of the admins verify this patch? |
Jack-Byrne
approved these changes
Feb 13, 2018
jacobkeeler
approved these changes
Feb 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1961
This PR is [ready] for review.
Risk
This PR makes [no] API changes.
Summary
Protect access to the "pt_" member variable of the cache_manager class with a recursive lock
CLA