Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChangeRegistration can respond with result = UNSUPPORTED_RESOURCE #3091

Merged

Conversation

iCollin
Copy link
Collaborator

@iCollin iCollin commented Oct 18, 2019

Fixes #1694

This PR is ready for review.

Risk

This PR makes minor API changes.

Testing Plan

Manually

Summary

The ChangeRegistration Response in the MOBILE_API lists a few different possible resultCodes that can be returned but does not list UNSUPPORTED_RESOURCE as one even though this can be returned. (by sending an unsupported ttsName for example)

Changelog

Enhancements
  • Makes it more clear to developers that UNSUPPORTED_RESOURCE can be returned from ChangeRegistration

CLA

@iCollin iCollin merged commit 1d3a401 into release/6.0.0 Oct 22, 2019
@iCollin iCollin deleted the fix/change_registration_responds_unsupported_resource branch October 22, 2019 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants