-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open INI file less #3688
Merged
Merged
Open INI file less #3688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobkeeler
requested changes
Apr 21, 2021
src/components/config_profile/include/config_profile/ini_file.h
Outdated
Show resolved
Hide resolved
Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
PR description is updated for the new approach |
jacobkeeler
requested changes
Apr 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, should still deprecate ini_read_value()
jacobkeeler
requested changes
Apr 23, 2021
src/components/config_profile/include/config_profile/ini_file.h
Outdated
Show resolved
Hide resolved
This reverts commit a03c694.
…eprecated methods
jacobkeeler
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2850
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Change INI value, run SDL core, ensure Core read new INI value
Unit Tests and ATF tests
Summary
Refactor INI parsing to reduce the number of times the ini file is opened. This goal is achieved through an update to Profile::UpdateValues:
Changelog
Enhancements
CMake
Tasks Remaining:
CLA