Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

print to console on crash from signal handler #3789

Merged
merged 1 commit into from Oct 7, 2021
Merged

print to console on crash from signal handler #3789

merged 1 commit into from Oct 7, 2021

Conversation

iCollin
Copy link
Collaborator

@iCollin iCollin commented Oct 7, 2021

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

Cause a core crash and observe the console output.

I caused a crash by reverting 86dd7b1 and sending IGNITION_OFF while streaming.
You can also send signals to core via kill.

Summary

Add a print to stderr in the signal handler before calling abort() or exit()

CLA

@iCollin iCollin merged commit 8306670 into develop Oct 7, 2021
@iCollin iCollin deleted the fix/print_on_crash branch October 7, 2021 18:46
@theresalech theresalech added this to In progress in 8.1.0 via automation Oct 11, 2021
@theresalech theresalech moved this from In progress to Completed Bug Fixes/ Enhancements in 8.1.0 Oct 11, 2021
@jacobkeeler jacobkeeler mentioned this pull request Apr 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jack-Byrne Jack-Byrne Jack-Byrne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
8.1.0
Completed Bug Fixes/ Enhancements
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iCollin @Jack-Byrne