Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/Clear endpoint_properties in policy DB if empty properties recieved in PTU #3880

Merged
merged 3 commits into from Mar 15, 2022

Conversation

ShobhitAd
Copy link
Contributor

@ShobhitAd ShobhitAd commented Mar 14, 2022

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

  • Manual testing with sdl_server. Test sending PTU with endpoint_properties: {}

Summary

Currently endpoint_properties is cleared from the cache if empty in PTU, but is not cleared from the policy database.

This PR

  • Adds a check for endpoint_properties.empty() in SaveServiceEndpointProperties.
  • If endpoint_properties.empty(), executes a query to clear the endpoint_properties in the policy DB.

CLA

@ShobhitAd ShobhitAd changed the title Fix/ Clear endpoint_properties from policy DB if empty properties recieved in PTU Fix/Clear endpoint_properties in policy DB if empty properties recieved in PTU Mar 14, 2022
@ShobhitAd ShobhitAd added this to In progress in 8.1.0 via automation Mar 14, 2022
@ShobhitAd ShobhitAd moved this from In progress to Bug Fixes in 8.1.0 Mar 14, 2022
8.1.0 automation moved this from Bug Fixes to Reviewer approved Mar 15, 2022
@ShobhitAd ShobhitAd merged commit 25e47c7 into release/8.1.0 Mar 15, 2022
@ShobhitAd ShobhitAd deleted the fix/empty_endpoint_properties_in_ptu branch March 15, 2022 21:21
8.1.0 automation moved this from Reviewer approved to Completed Features Mar 15, 2022
@ShobhitAd ShobhitAd moved this from Completed Features to Completed Bug Fixes/ Enhancements in 8.1.0 Mar 15, 2022
@jacobkeeler jacobkeeler mentioned this pull request Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
8.1.0
Completed Bug Fixes/ Enhancements
Development

Successfully merging this pull request may close these issues.

None yet

2 participants