Fix potential crashes by using shared pointers for app data #3900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@VjKlepikov can you verify if this fixes the issue on your end? |
Jack-Byrne
approved these changes
Apr 7, 2022
|
@jacobkeeler Issue is not reproduced on e30057e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3892
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Run ./test_scripts/Smoke/Resumption/005_Resumption_big_amount_of_data.lua repeatedly (listed in issue)
Summary
Use shared pointers instead of raw pointers for app data to prevent potential deallocation while reading data
Changelog
Bug Fixes
CLA