Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation Subscription Buttons Implementation #187

Merged
merged 2 commits into from
Jul 22, 2019
Merged

Navigation Subscription Buttons Implementation #187

merged 2 commits into from
Jul 22, 2019

Conversation

Jack-Byrne
Copy link
Collaborator

Implements/Fixes #182

This PR is Ready for review.

Testing Plan

  • Connect and activate a navigation app.
  • Subscribe to a new navigation button.
  • Click on "Nav Buttons" button to open list of nav buttons.
  • Click on a button and verify the button events are received by the mobile app.

Summary

Creates a new menu like view to house all of the navigation subscription buttons. Long and short presses are supported.

CLA

@Jack-Byrne Jack-Byrne merged commit de209bb into develop Jul 22, 2019
@theresalech theresalech mentioned this pull request Jul 22, 2019
Closed
@jacobkeeler jacobkeeler deleted the feature/navigation_subscription_buttons branch March 18, 2020 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShobhitAd ShobhitAd ShobhitAd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jack-Byrne @ShobhitAd