Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The File Manager will not send images if the ListFiles request is rejected by the module due to encryption #1975

Closed
NicoleYarroch opened this issue Apr 20, 2021 · 0 comments · Fixed by #1977
Assignees
Labels
bug A defect in the library manager-encryption Related to the encryption manager for RPC service encryption manager-lifecycle Relating to the manager layer - lifecycle manager

Comments

@NicoleYarroch
Copy link
Contributor

Bug Report

If the SDLFileManager sends a ListFiles request and the module rejects it because it needs to be encrypted, the file manager transitions to the error state and no artworks can be sent.

Technically, the SDLFileManager should either 1) not send the ListFiles request until the encryption manager has been setup or 2) it should send the ListFiles request again when the encryption manager has been setup.

A quick workaround would be to check in didEnterStateFetchingInitialList if [error.userInfo[@"resultCode"] isEqualToEnum:SDLResultEncryptionNeeded] and just transition to the SDLFileManagerStateReady if so. This means that the library will waste time re-uploading artworks that already exist on the module but it works as a temporary fix until the SDLFileManager can be reworked to add a dependency on the encryption manager.

Reproduction Steps
  1. Configure the module to require encryption for the ListFiles RPC.
  2. Connect the SDL app to the module and launch the SDL app.
Expected Behavior

The artworks in the Show request should show up.

Observed Behavior

The artworks for the Show request are never sent to the module due to the SDLFileManager being in the error state.

OS & Version Information
  • iOS Version: n/a
  • SDL iOS Version: 7.1
  • Testing Against: sdl_core (commit d7c804de1e5bc90f9359ea21b9d9c54de70bb947 (HEAD -> develop, origin/develop))
@NicoleYarroch NicoleYarroch added bug A defect in the library manager-lifecycle Relating to the manager layer - lifecycle manager manager-encryption Related to the encryption manager for RPC service encryption labels Apr 20, 2021
@NicoleYarroch NicoleYarroch self-assigned this Apr 21, 2021
@joeljfischer joeljfischer mentioned this issue May 24, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library manager-encryption Related to the encryption manager for RPC service encryption manager-lifecycle Relating to the manager layer - lifecycle manager
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants