Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDL 0027] Increase Specificity of Handler Events #537

Closed
theresalech opened this issue Feb 15, 2017 · 0 comments
Closed

[SDL 0027] Increase Specificity of Handler Events #537

theresalech opened this issue Feb 15, 2017 · 0 comments
Labels
proposal Accepted SDL Evolution Proposal
Projects
Milestone

Comments

@theresalech
Copy link
Contributor

Proposal: Increase Specificity of Handler Events

The purpose of this proposal is to make notification handlers more specific. Currently, the developer is required to know how to cast a notification parameter within the handler in order to properly use that notification. This proposal changes handlers to provide greater specificity on all RPCs that support them, as well as to separate out button handlers into two separate types. This will involve major version changes to remove old versions of the handlers that will no longer be supported.

Review: smartdevicelink/sdl_evolution#89

SDLC Steering Committee Decision:

The Steering Committee has accepted this proposal, given the following revisions: the SDLRPCButtonEventNotificationHandler and SDLRPCButtonPressNotificationHandler would be combined into one handler instead, with the signature: typedef void (^SDLButtonActionNotificationHandler)(__nullable SDLOnButtonPress *buttonPress, __nullable SDLOnButtonEvent *buttonEvent);

@theresalech theresalech added the proposal Accepted SDL Evolution Proposal label Feb 15, 2017
joeljfischer added a commit that referenced this issue Feb 22, 2017
* Fixes #537
* Update button & command handlers to be specific
@joeljfischer joeljfischer modified the milestone: 5.0.0 Mar 8, 2017
@joeljfischer joeljfischer added this to Done in v5.0.0 Apr 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal Accepted SDL Evolution Proposal
Projects
No open projects
Development

No branches or pull requests

2 participants