SDLUploadFileOperation is not finished on error

[t-yoshii]

Bug Report

SDLUploadFileOperation is not finished on error, and keep staying in SDLFileManager's operation queue. This cause succeeding operations not being executed.

In SDL Manager connection and reconnection phase, SDLFileManager uses SDLListFilesOperation at FetchingInitialFileList and SDLUploadFileOperation at SettingUpAppIcon operations in 1 queue with maxConcurrentOperationCount = 1.

If SDLUploadFileOperation fails, it does not call finishOperation and stays in transaction queue. This blocks succeeding operations to be executed.

Reproduction Steps

We hit this issue on reconnection test.

1. Disconnect SDL core.
2. SDLManager starts reconnection.
3. SDLListFilesOperation is executed at FetchingInitialFileList
4. SDLUploadFileOperation is executed at SettingUpAppIcon and it fails.
5. Reconnection success.
6. Disconnect SDL core.
7. SDLManager starts reconnection.
8. SDLListFilesOperation is queued at FetchingInitialFileList but is not executed because last SDLUploadFileOperation stays in queue.

Expected Behavior

SDLListFilesOperation is executed even after SDLUploadFileOperation had failed.

Observed Behavior

SDLListFilesOperation is not executed

OS & Version Information

• iOS Version: 11
• SDL iOS Version: 5.1.1
• Testing Against: Our internal HU devboard.

Test Case, Sample Code, and / or Example App

I will create PR later.