Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDLUploadFileOperation is not finished on error #860

Closed
t-yoshii opened this issue Feb 6, 2018 · 0 comments

Comments

@t-yoshii
Copy link

commented Feb 6, 2018

Bug Report

SDLUploadFileOperation is not finished on error, and keep staying in SDLFileManager's operation queue. This cause succeeding operations not being executed.

In SDL Manager connection and reconnection phase, SDLFileManager uses SDLListFilesOperation at FetchingInitialFileList and SDLUploadFileOperation at SettingUpAppIcon operations in 1 queue with maxConcurrentOperationCount = 1.

If SDLUploadFileOperation fails, it does not call finishOperation and stays in transaction queue. This blocks succeeding operations to be executed.

Reproduction Steps

We hit this issue on reconnection test.

  1. Disconnect SDL core.
  2. SDLManager starts reconnection.
  3. SDLListFilesOperation is executed at FetchingInitialFileList
  4. SDLUploadFileOperation is executed at SettingUpAppIcon and it fails.
  5. Reconnection success.
  6. Disconnect SDL core.
  7. SDLManager starts reconnection.
  8. SDLListFilesOperation is queued at FetchingInitialFileList but is not executed because last SDLUploadFileOperation stays in queue.
Expected Behavior

SDLListFilesOperation is executed even after SDLUploadFileOperation had failed.

Observed Behavior

SDLListFilesOperation is not executed

OS & Version Information
  • iOS Version: 11
  • SDL iOS Version: 5.1.1
  • Testing Against: Our internal HU devboard.
Test Case, Sample Code, and / or Example App

I will create PR later.

@joeljfischer joeljfischer added the bug label Feb 6, 2018

@joeljfischer joeljfischer added this to the 5.2.0 milestone Feb 6, 2018

@joeljfischer joeljfischer added this to Donations in v5.2.0 Feb 6, 2018

v5.2.0 automation moved this from Donations to Done Feb 9, 2018

@joeljfischer joeljfischer referenced this issue Mar 16, 2018
2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.