Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIViews accessed on background thread for hit testing when SDLTouchManager calls SDLTouchManagerDelegate methods #875

Closed
Lievesley opened this issue Feb 23, 2018 · 1 comment
Assignees
Labels
bug A defect in the library
Milestone

Comments

@Lievesley
Copy link

Lievesley commented Feb 23, 2018

Bug Report

UIViews are accessed on a background thread while hit testing when SDLTouchManager calls SDLTouchManagerDelegate methods.

Reproduction Steps
  1. Enable main thread checker.
  2. Run build in debugger and use touch events with hit testing.
  3. SDLTouchManager calls [SDLFocusableItemLocator viewForPoint] which accesses UIViews on background thread.
Expected Behavior

UIViews should only be accessed on main thread.
The SDLTouchManager should also not call SDLTouchManagerDelegate methods on a background thread since it sends UIViews which may lead the callee to try to use the UIView on the background thread.

Observed Behavior

UIViews accessed on background thread.

OS & Version Information
  • iOS Version: 11.0.3
  • SDL iOS Version: 5.1.1
@joeljfischer joeljfischer added this to the 5.2.0 milestone Feb 23, 2018
@joeljfischer joeljfischer added the bug A defect in the library label Feb 23, 2018
@NicoleYarroch NicoleYarroch self-assigned this Feb 26, 2018
@NicoleYarroch
Copy link
Contributor

Pull Request #833 was created to fix this bug

@joeljfischer joeljfischer mentioned this issue Mar 16, 2018
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library
Projects
None yet
Development

No branches or pull requests

3 participants