Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection retry counter should be reset at accessory connection #921

Closed
t-yoshii opened this issue Mar 30, 2018 · 0 comments
Closed

Connection retry counter should be reset at accessory connection #921

t-yoshii opened this issue Mar 30, 2018 · 0 comments
Labels
bug A defect in the library
Projects
Milestone

Comments

@t-yoshii
Copy link

Bug Report

Connection retry counter should be reset at accessory connection.

SDL Proxy tries to connect and increment retry counter even external accessory is not detected. This can waste the chance to retry connection after accessory is connected.

Reproduction Steps
  1. Start SDL app and start SDL proxy. HU (external accessory) is not ready
  2. Make app background and make it foreground again. SDL Proxy tries to connect but it fail because HU is not ready. Retry counter is incremented.
  3. Repeat 2 more than 2.
  4. HU connection become available.
  5. SDL app detects accessory connection, however, connection is not retried because already exceeds retry counter (=3).
Expected Behavior

SDL proxy retry connection at 5.

Observed Behavior

SDL proxy does not retry at 5.

OS & Version Information
  • iOS Version: All
  • SDL iOS Version: 5.1.1, 5.2.0
  • Testing Against: Our internal devboard
Test Case, Sample Code, and / or Example App

I will create PR later.

@joeljfischer joeljfischer modified the milestones: 5.2.0, 5.3.0 Apr 4, 2018
@joeljfischer joeljfischer added the bug A defect in the library label Apr 4, 2018
@joeljfischer joeljfischer added this to Donations in v6.0.0 Apr 4, 2018
@joeljfischer joeljfischer moved this from Donations to Done in v6.0.0 Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library
Projects
No open projects
v6.0.0
  
Done
Development

No branches or pull requests

2 participants