Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDLShow initializer will crash if SDLMetadataType is nil #966

Closed
joeljfischer opened this issue May 17, 2018 · 0 comments
Closed

SDLShow initializer will crash if SDLMetadataType is nil #966

joeljfischer opened this issue May 17, 2018 · 0 comments
Assignees
Labels
bug A defect in the library
Projects
Milestone

Comments

@joeljfischer
Copy link
Contributor

Bug Report

If SDLShow initWithMainField1:(nullable NSString *)mainField1 mainField1Type:(nullable SDLMetadataType)mainField1Type mainField2:(nullable NSString *)mainField2 mainField2Type:(nullable SDLMetadataType)mainField2Type alignment:(nullable SDLTextAlignment)alignment is called with a nil mainField1(/2)Type, a crash will occur, even though those parameters are listed as nullable.

Reproduction Steps
  1. Call initWithMainField1:(nullable NSString *)mainField1 mainField1Type:(nullable SDLMetadataType)mainField1Type mainField2:(nullable NSString *)mainField2 mainField2Type:(nullable SDLMetadataType)mainField2Type alignment:(nullable SDLTextAlignment)alignment with nil mainField1Type.
Expected Behavior

The method returns successfully without that parameter set

Observed Behavior

An exception crash occurs

OS & Version Information
  • iOS Version: n/a
  • SDL iOS Version: v5.3.0 WIP
  • Testing Against: n/a
@joeljfischer joeljfischer added the bug A defect in the library label May 17, 2018
@joeljfischer joeljfischer added this to the 6.0.0 milestone May 17, 2018
@joeljfischer joeljfischer self-assigned this May 17, 2018
@joeljfischer joeljfischer added this to Bug Backlog in v6.0.0 May 18, 2018
@joeljfischer joeljfischer moved this from Bug Backlog to In Review in v6.0.0 May 18, 2018
v6.0.0 automation moved this from In Review to Done May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library
Projects
No open projects
v6.0.0
  
Done
Development

No branches or pull requests

1 participant