Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement SDL-0041 - App Icon Resumption #1033

Merged
merged 3 commits into from Aug 17, 2018
Merged

Implement SDL-0041 - App Icon Resumption #1033

merged 3 commits into from Aug 17, 2018

Conversation

joeljfischer
Copy link
Contributor

@joeljfischer joeljfischer commented Jul 23, 2018 •
edited

Fixes #600

This PR is ready for review.

Risk

This PR makes minor API changes.

Testing Plan

Unit tests will be added

Summary

Implements SDL-0041 to enable app icon resumption.

Changelog

Enhancements
  • The app icon can now be resumed after the first time it's been uploaded, so that the developer does not need to upload the icon on every connection. (SDL-0041).

Tasks Remaining:

  • Add unit tests
  • Test against Core 5.0

CLA

@joeljfischer
Implement SDL-0041 App Icon Resumption
f3f592c 
* Add support for icon resumption
@joeljfischer joeljfischer self-assigned this Jul 23, 2018
@joeljfischer joeljfischer added enhancement proposal Accepted SDL Evolution Proposal labels Jul 23, 2018
@joeljfischer joeljfischer added this to the 6.1.0 milestone Jul 23, 2018
@joeljfischer joeljfischer merged commit a02712b into develop Aug 17, 2018
@joeljfischer joeljfischer deleted the feature/issue_600_appicon_resumption branch August 17, 2018 14:11
@NicoleYarroch NicoleYarroch mentioned this pull request Jan 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicoleYarroch NicoleYarroch NicoleYarroch approved these changes

Assignees

@joeljfischer joeljfischer

Labels
proposal Accepted SDL Evolution Proposal
Projects
None yet
Milestone
6.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joeljfischer @NicoleYarroch