Support SDLSystemCapabilityManager Subscriptions #1279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Unit test updates * Block and selector based subscriptions
joeljfischer
added
enhancement
best practice
* Add documentation
NicoleYarroch
suggested changes
May 28, 2019
NicoleYarroch
approved these changes
May 29, 2019
joeljfischer
deleted the
feature/issue_1222_align_systemcapabilitymanager_callbacks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1222, #1278
This PR is ready for review.
Risk
This PR makes minor API changes.
Testing Plan
Unit tests have been updated
Summary
This PR adds a few new methods to subscribe to individual
SystemCapabilityTypes. You can subscribe either using a selector or a block, and the unsubscribe. This basically matches with Java'saddOnSystemCapabilityListener()andremoveOnSystemCapabilityListener()methods.Changelog
Enhancements
SystemCapabilityTypethrough theSDLSystemCapabilityManager.Bug Fixes
SDLSystemCapabilityManagerwill update its properties based on "outside"GetSystemCapabilityResponses.CLA