Change example app resultCode check to the success bool instead #1459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeljfischer
added
bug
NicoleYarroch
approved these changes
Oct 23, 2019
joeljfischer
deleted the
bugfix/issue-1456-example-app-warning-alert-template-change
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1456
This PR is not ready for review.
Risk
This PR makes no API changes.
Testing Plan
To be tested against Core 6.0
Summary
This PR updates the example apps to not show a warning alert when the
SetDisplayLayoutreturns aWARNINGSresult code on Core 6.0+ due to the deprecation ofSetDisplayLayout.Changelog
Bug Fixes
Tasks Remaining:
CLA