Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed code from swift example that checks for first time hmiLevel i… #1574

Merged
merged 1 commit into from Mar 9, 2020
Merged

removed code from swift example that checks for first time hmiLevel i… #1574

merged 1 commit into from Mar 9, 2020

Conversation

lapinskijw
Copy link
Contributor

Fixes #1554

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).

Unit Tests

All changes are in example app, unit tests not needed.

Core Tests

n/a Core unaffected by changes.

Summary

Removed the check in the example Swift app that checks for first hmiLevel FULL.

Changelog

Bug Fixes
  • Removed unused method if statement.

CLA

@lapinskijw lapinskijw added bug A defect in the library example app Relating to the built-in example apps labels Feb 28, 2020
@NicoleYarroch NicoleYarroch added this to In progress in v6.6.0 via automation Feb 28, 2020
v6.6.0 automation moved this from In progress to Reviewer approved Feb 28, 2020
v6.6.0 automation moved this from Reviewer approved to Waiting for Review Mar 3, 2020
@joeljfischer joeljfischer merged commit a662ea4 into develop Mar 9, 2020
v6.6.0 automation moved this from Waiting for Review to Done Mar 9, 2020
@joeljfischer joeljfischer deleted the bugfix/issue-1554-swift-example-app-hmilevel branch March 9, 2020 15:41
@theresalech theresalech mentioned this pull request Mar 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeljfischer joeljfischer joeljfischer requested changes

@NicoleYarroch NicoleYarroch NicoleYarroch approved these changes

Assignees

@lapinskijw lapinskijw

Labels
bug A defect in the library example app Relating to the built-in example apps
Projects
No open projects
v6.6.0
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lapinskijw @joeljfischer @NicoleYarroch