Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nullable attribute to lockScreenDismissalEnabled and lockScreenDismissalWarning #1822

Conversation

FrankElias77
Copy link
Contributor

Fixes #1813

Risk

This PR makes minor API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).

Unit Tests

Unit tests added for the lockScreenDismissalWarning property.

Core Tests

N/A

Core version / branch / commit hash / module tested against: 7.0
HMI name / version / branch / commit hash / module tested against: N/A

Summary

Added the nullable attribute to mentioned properties.

Changelog

Breaking Changes
  • N/A
Enhancements
  • N/A
Bug Fixes
  • Added the nullable attribute to mentioned properties.

Tasks Remaining:

N/A

CLA

Add nullable attribute to lockScreenDismissalEnabled and lockScreenDismissalWarning
@FrankElias77 FrankElias77 added the bug A defect in the library label Oct 20, 2020
@FrankElias77 FrankElias77 added this to In progress in v7.0.0 via automation Oct 20, 2020
@FrankElias77 FrankElias77 self-assigned this Oct 20, 2020
@codecov
Copy link

codecov bot commented Oct 20, 2020

Codecov Report

Merging #1822 into develop will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1822      +/-   ##
===========================================
+ Coverage    84.61%   84.63%   +0.01%     
===========================================
  Files          418      418              
  Lines        20939    20939              
===========================================
+ Hits         17718    17721       +3     
+ Misses        3221     3218       -3     

Add missing tests for lockScreenDismissalWarning
@FrankElias77 FrankElias77 marked this pull request as ready for review October 20, 2020 15:13
v7.0.0 automation moved this from In progress to Review in progress Oct 20, 2020
Comment review
v7.0.0 automation moved this from Review in progress to Reviewer approved Oct 26, 2020
@joeljfischer joeljfischer merged commit 958ae89 into develop Oct 26, 2020
v7.0.0 automation moved this from Reviewer approved to Done Oct 26, 2020
@joeljfischer joeljfischer deleted the bugfix/issue-1813-some-properties-in-the-OnDriverDistraction-are-missing-nullable-attribute branch October 26, 2020 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library
Projects
No open projects
v7.0.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants