Fixes StartService RPC not ACKed on IVI boot #1951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jordynmackool @smartdevicelink/ios PR is ready for review. Thanks! |
|
@mrapitis thanks for letting us know. Livio will work to review this PR following the upcoming April 14, 2021 release. Once this PR is approved by Livio, the Steering Committee can then discuss/plan a two-week review and testing period as requested in this comment . |
joeljfischer
added
bug
|
Hi @mrapitis, this PR does not include changes for unit tests. I have attached a patch file with the necessary changes due to this already being under SDLC steering committee review. Thanks! |
Codecov Report
@@ Coverage Diff @@
## develop #1951 +/- ##
===========================================
+ Coverage 83.63% 85.07% +1.43%
===========================================
Files 441 441
Lines 22534 22573 +39
===========================================
+ Hits 18847 19204 +357
+ Misses 3687 3369 -318 |
7 tasks
This was referenced May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1783
This PR is ready for review.
Risk
This PR makes [no] API changes.
Testing Plan
Unit Tests
Create multiple SDL sample apps configured to use iAP transport. Install all the apps on an iPhone and connect the iPhone over the iAP transport (usb / bt) and verify that connectivity is stable and reliable for all use cases including ignition / power cycles, usb disconnects / reconnects events, bt disconnect / reconnect events and transport switching between usb and bt.
Core Tests
Verified connectivity with sdl core over wifi transport continues to be reliable and is not impacted.
Core version / branch / commit hash / module tested against: SYNC 3.0, 4.0, 7.1.0-RC
HMI name / version / branch / commit hash / module tested against: Sync HMI, SDL HMI
Summary
Removed rpcStartServiceTimeoutTimer as recommended at links below
#1783 (comment)
#1783 (comment)
Changelog
Bug Fixes
CLA