Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SDL 0072 New vehicle data - FuelRange #722

Conversation

mrapitis
Copy link
Contributor

@mrapitis mrapitis commented Sep 1, 2017

Fixes #641

This PR is ready for review.

Risk

This PR makes minor API changes.

Testing Plan

Added new unit tests and expanded existing ones

Summary

Added Vehicle Data RPC's, structs, enums as defined in the fuel range proposal.

CLA

  • I have signed the CLA

@joeljfischer
Copy link
Contributor

@mrapitis This hasn't been scheduled for Core v4.4, so this won't be merged for probably 6 months and a lot can change between now and then. Do you want to keep this open until then?

@mrapitis
Copy link
Contributor Author

mrapitis commented Sep 5, 2017

@joeljfischer Would it be possible to review / merge the proxy side changes prior to the core implementation?

@joeygrover
Copy link
Member

joeygrover commented Sep 5, 2017

@mrapitis unfortunately, no. We are no longer merging in RPC additions on whims. We are merging them in based on RPC spec versions. This makes it much clearer which version of the proxy support which version of the RPC spec. It is also impossible to test against core until those changes are made on core. The next RPC spec will need to be approved with that addition before it gets merged into the proxy.

@mrapitis
Copy link
Contributor Author

mrapitis commented Sep 5, 2017

@joeygrover Understood, I'll close for now and resubmit when we have an approved version.

@mrapitis mrapitis closed this Sep 5, 2017
@mrapitis mrapitis changed the base branch from release/5.0.0 to develop March 12, 2018 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants